Tweak wording in using-notebooks #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding raises-exception support may be out of scope for vscode-jupyter due to lack of widespread interest in the feature. This slightly rewords the second on VS Code to avoid falsely implying that the project has committed to adding raises-exception support or that it will necessarily be added. Further refinement may be possible in the future, but I'm doing this small rewording now to avoid potentially confusing inaccuracy.
EliahKagan
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit c01eedc.
EliahKagan
added a commit
that referenced
this pull request
Dec 4, 2023
It looks like the feature is being added to vscode-jupyter! This reverts the wording since the old wording turns out more accurate, but I'll want to update this again once I've checked the details and (if ready) tried it out on our notebooks with raises-exception. This reverts commit c01eedc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding raises-exception support may be out of scope for vscode-jupyter due to lack of widespread interest in the feature. This slightly rewords the second on VS Code to avoid falsely implying that the project has committed to adding raises-exception support or that it will necessarily be added.
Further refinement may be possible in the future, but I'm doing this small rewording now to avoid potentially confusing inaccuracy.